Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rust-code-analysis for mozilla-central #270

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Fix rust-code-analysis for mozilla-central #270

merged 2 commits into from
Oct 8, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Sep 14, 2020 •
edited
Loading

  • Fix a wrong logic
  • Remove a blocking unwrap function

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman September 14, 2020 13:31
@Luni-4 Luni-4 changed the title Remove some blocking unwrap functions Fix rust-code-analysis for mozilla-central Sep 14, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020 •
edited
Loading

Codecov Report

Merging #270 into master will decrease coverage by 0.01%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   19.99%   19.97%   -0.02%     
==========================================
  Files          47       47              
  Lines        6148     6152       +4     
  Branches      798      800       +2     
==========================================
  Hits         1229     1229              
- Misses       4406     4409       +3     
- Partials      513      514       +1
Impacted Files Coverage Δ
rust-code-analysis-cli/src/main.rs 0.00% <0.00%> (ø)
src/spaces.rs 60.92% <72.72%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe397f...81425d3. Read the comment docs.

calixteman
calixteman reviewed Oct 5, 2020
View reviewed changes
src/spaces.rs Outdated Show resolved Hide resolved
calixteman
calixteman reviewed Oct 5, 2020
View reviewed changes
src/spaces.rs Outdated Show resolved Hide resolved
calixteman
calixteman previously approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just fix the nits to have a nicer code.

@Luni-4 Luni-4 requested a review from calixteman October 5, 2020 09:11
calixteman
calixteman reviewed Oct 5, 2020
View reviewed changes
src/spaces.rs Outdated Show resolved Hide resolved
@Luni-4 Luni-4 requested a review from calixteman October 5, 2020 10:08
calixteman
calixteman approved these changes Oct 8, 2020
View reviewed changes
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@calixteman calixteman merged commit 73a0931 into mozilla:master Oct 8, 2020
@Luni-4 Luni-4 deleted the fix-spaces branch October 9, 2020 07:19
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
@Luni-4 @spacedragon
Fix rust-code-analysis for mozilla-central (mozilla#270)
794d7d2 
* Fix how spaces are merged

* Remove a blocking unwrap function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luni-4 @codecov-commenter @calixteman